feat(issue-discovery): precise post-merge edit detection upgrade by corevibe555 · Pull Request #434 · entrius/gittensor

corevibe555 · 2026-04-15T01:07:20Z

Closes #402

Summary

Replaces the issue.updated_at anti-gaming logic in issue discovery scoring with precise timeline-based detection for body and title edits only. The old check false-positived on any activity (bot comments, label changes, reactions, stale-bots), silently demoting legitimate solved issues to closed_count and unfairly cutting miner credibility in active repos.

Body edit and title edit both should be checked.
This is because title and body are connected.
If title change allowed, it's possible to confuse the reviewer by changing title.
From the purpose of this feature from doc: https://docs.gittensor.io/issue-discovery.html, title is important to define scope, it's possible to inflate by just changing title.

Related Issues

Closes #402

Type of Change

Testing

Added: tests/validator/test_issue_discovery_post_merge_edit.py — 3 cases:

Benign updated_at bump after merge (bot activity) → issue stays solved.
Real body edit after merge → issue demoted to closed, no score.
Body edit before merge → ignored, stays solved.

Results: 3/3 new tests pass. Broader existing suite (66 validator tests) still green. Pre-existing tree_sitter import errors in unrelated test modules are not affected by this change.

Manual testing

Create an issue on open source repo. in my case, created one issue here: https://github.com/corevibe555/corevibe555/issues
Create a new branch and create PR, mention "Closes rehaul weights #3" in PR description, merge PR
If you go to issues list, the issue is closed.
The best way to see updated_at is changed is adding a comment, so please add a new comment to that closed issue rehaul weights #3, see the screenshot.
Change title case, attached screenshot
Change body case, attached screenshot

Before adding comment

After adding commment

After changing title

After chaing body

Checklist

Code follows project style
Self-review completed (follow-up noted: body_or_title_edited_at is not persisted to DB — fine today since scoring re-fetches from GraphQL each run, but worth revisiting if any code path reconstructs Issue from storage)
Comments explain non-obvious why, not what
New tests added and passing
No schema/migration changes required (updated_at column preserved)
Documentation update pending — issue_discovery/issue-discovery-rewards.md still describes the updated_at proxy as current behavior; should be updated in a follow-up doc PR or this one if preferred

corevibe555 · 2026-04-15T01:39:04Z

                  authorAssociation
+                  userContentEdits(last: 1) {
+                    nodes { editedAt }
+                  }


To get last body edit, first:1 will return newest edit time, proved by manual testing

corevibe555 · 2026-04-15T01:39:22Z

+                    nodes {
+                      ... on RenamedTitleEvent { createdAt }
+                    }
+                  }


To get last title edit time of the issue.

corevibe555 · 2026-04-15T13:40:12Z

@anderdc Would you review this PR?
This is critical feature enhancement.

anderdc

A couple things to address:

Delete the spec file

issue_discovery/issue-discovery-rewards.md is a planning doc that was used to guide implementation. It shouldn't live in the repo long-term. Please delete it in this PR or a follow-up.

Clean up the tests

The tests cover the right scenarios but need some cleanup:

_make_issue has datetime = None defaults — these should be Optional[datetime] = None
Lazy import of _DiscovererData inside _run() — no reason for this in a test file, just import at the top
_merged_at() is a function returning a constant — just make it a module-level constant
Make sure the tests are actually exercising the new code path — right now they test _collect_issues_from_prs (a private function) directly. That's fine for now, but double check the assertions are meaningful and not just passing because of default values or skipped branches

anderdc · 2026-04-15T19:05:36Z

failing ci

corevibe555 · 2026-04-15T22:52:27Z

@anderdc Updated the PR. Would you review again? Thanks

Replace the noisy updated_at proxy with timeline-based detection for body and title edits only. updated_at fires on any activity (bot comments, labels, reactions), silently demoting legitimate solved issues to closed_count in active repos. - GraphQL: fetch userContentEdits + RenamedTitleEvent alongside existing closingIssuesReferences (no extra round trip) - Issue.body_or_title_edited_at: max(last body edit, last rename) - scoring.py: anti-gaming check now uses body_or_title_edited_at - Tests: benign updated_at bump ignored, real body edit demotes, pre-merge edits ignored fix fix fix fix

userContentEdits is reverse-chronological on GitHub, so last:1 returned the oldest body edit and the check never fired on subsequent edits. first:1 returns the newest. timelineItems is chronological, so last:1 stays correct for title renames.

- Optional[datetime] on _make_issue defaults (fixes pyright) - Hoist _DiscovererData / defaultdict imports to module level - Replace _merged_at() function with MERGED_AT constant - Delete issue_discovery/issue-discovery-rewards.md planning doc

anderdc

Solid upgrade. The updated_at proxy was a known false-positive source (bot comments, labels, reactions demoting legitimate solved issues). The timeline-based approach is precise and well-tested.

GraphQL pagination is correct: first:1 for reverse-chronological userContentEdits, last:1 for chronological timelineItems
Null handling is robust throughout the parsing chain
Tests cover the three key cases: benign activity ignored, real post-merge edit caught, pre-merge edit ignored
CI green: pyright, ruff, tests all pass

corevibe555 force-pushed the feature/issue-402-post-merge-edit-detection branch from 7a98b6a to 4adaf12 Compare April 15, 2026 01:12

corevibe555 changed the title ~~[WIP] feat(issue-discovery): precise post-merge edit detection (#402)~~ feat(issue-discovery): precise post-merge edit detection (#402) Apr 15, 2026

corevibe555 commented Apr 15, 2026

View reviewed changes

corevibe555 force-pushed the feature/issue-402-post-merge-edit-detection branch 2 times, most recently from 5ac412c to a4af442 Compare April 15, 2026 01:52

corevibe555 changed the title ~~feat(issue-discovery): precise post-merge edit detection (#402)~~ feat(issue-discovery): precise post-merge edit detection upgrade Apr 15, 2026

anderdc closed this Apr 15, 2026

anderdc reopened this Apr 15, 2026

anderdc requested changes Apr 15, 2026

View reviewed changes

anderdc mentioned this pull request Apr 15, 2026

fix: exclude auto-close event from post-merge edit detection in issue discovery scoring #444

Closed

7 tasks

corevibe555 force-pushed the feature/issue-402-post-merge-edit-detection branch 2 times, most recently from 01614b9 to f5c2e94 Compare April 15, 2026 22:41

corevibe555 requested a review from anderdc April 15, 2026 22:52

corevibe555 and others added 6 commits April 16, 2026 04:39

style: ruff format

a210ee0

style: drop unused variable in test

a92a7cf

fix: fix ruff issue

f297b9d

corevibe555 force-pushed the feature/issue-402-post-merge-edit-detection branch from bd162f0 to f297b9d Compare April 16, 2026 01:39

anderdc approved these changes Apr 16, 2026

View reviewed changes

anderdc merged commit 07b0cb4 into entrius:test Apr 16, 2026
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(issue-discovery): precise post-merge edit detection upgrade#434

feat(issue-discovery): precise post-merge edit detection upgrade#434
anderdc merged 6 commits intoentrius:testfrom
corevibe555:feature/issue-402-post-merge-edit-detection

corevibe555 commented Apr 15, 2026 •

edited

Loading

Uh oh!

corevibe555 Apr 15, 2026 •

edited

Loading

Uh oh!

corevibe555 Apr 15, 2026

Uh oh!

corevibe555 commented Apr 15, 2026

Uh oh!

anderdc left a comment

Uh oh!

anderdc commented Apr 15, 2026

Uh oh!

corevibe555 commented Apr 15, 2026

Uh oh!

anderdc left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

corevibe555 commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Issues

Type of Change

Testing

Manual testing

Checklist

Uh oh!

corevibe555 Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

corevibe555 Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

corevibe555 commented Apr 15, 2026

Uh oh!

anderdc left a comment

Choose a reason for hiding this comment

Uh oh!

anderdc commented Apr 15, 2026

Uh oh!

corevibe555 commented Apr 15, 2026

Uh oh!

anderdc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

corevibe555 commented Apr 15, 2026 •

edited

Loading

corevibe555 Apr 15, 2026 •

edited

Loading