Refactor/deduplicate config path constants#436
Merged
anderdc merged 4 commits intoentrius:testfrom Apr 15, 2026
Merged
Conversation
10587ea to
2f463fd
Compare
anderdc
requested changes
Apr 15, 2026
2f463fd to
99cd926
Compare
Contributor
Author
|
Hi, @anderdc One thing worth noting: option 2 (keep in main.py, import from there in helpers.py) would create a circular import - Option 1 (define in |
anderdc
previously approved these changes
Apr 15, 2026
Collaborator
anderdc
left a comment
There was a problem hiding this comment.
I see what you mean, we'll just leave it as is, simple dedup
Contributor
Author
|
Thanks for your review, @anderdc |
6545c71 to
a071050
Compare
Contributor
Author
|
Hi, @anderdc |
anderdc
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GITTENSOR_DIRandCONFIG_FILEwere defined identically in two places:cli/main.py:28-29cli/issue_commands/helpers.py:48-49Moves the canonical definition to
gittensor/constants.py. Both files now import from there.Also removes the now-unused
from pathlib import Pathimport fromhelpers.py.Test plan
pytest tests/cli/ tests/utils/, no new failures