Skip to content

fix: return non-zero when PAT broadcast or check fails everywhere#550

Closed
reganbuilds wants to merge 1 commit into
entrius:testfrom
reganbuilds:fix/miner-check-post-nonzero-on-zero-accept
Closed

fix: return non-zero when PAT broadcast or check fails everywhere#550
reganbuilds wants to merge 1 commit into
entrius:testfrom
reganbuilds:fix/miner-check-post-nonzero-on-zero-accept

Conversation

@reganbuilds
Copy link
Copy Markdown
Contributor

Summary

  • return exit code 1 from gitt miner post when zero validators accept the PAT
  • return exit code 1 from gitt miner check when zero validators report a valid PAT
  • add focused CLI tests for both failure paths

Fixes #542.

Validation

  • exercised both CLI paths through Click runner with mocked bittensor and synapse dependencies
  • ran python3 -m py_compile gittensor/cli/miner_commands/post.py gittensor/cli/miner_commands/check.py tests/cli/test_miner_commands.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

miner check/post exit 0 when zero validators accept PAT

2 participants