fix: json mode and human mode disagree on exit codes and aggregates#724
Open
andriypolanski wants to merge 6 commits intoentrius:testfrom
Open
fix: json mode and human mode disagree on exit codes and aggregates#724andriypolanski wants to merge 6 commits intoentrius:testfrom
andriypolanski wants to merge 6 commits intoentrius:testfrom
Conversation
Author
|
@anderdc |
8 tasks
Author
|
@anderdc |
Collaborator
|
Fix CI |
Author
|
@anderdc |
86b212c to
803b8cd
Compare
Author
|
Hi, @anderdc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gitt issues list --id— Missing on-chain issue: JSON already exited non-zero with a structured error; human mode exited 0 after a soft warning. Both paths now use the same helper as other issue commands (handle_exception) so exit code and error shape stay consistent.gitt miner check --json-output— The top-levelinvalidcount mixed “no PAT” (has_pat is False) with “invalid PAT” rows. JSON now exposesno_pat,invalid_pat, andno_response(plusvalid), matching the human table semantics.invalidis removed from the JSON payload (breaking change for scripts that read that field).Related Issues
Closes #723
Type of Changes
Tests
tests/cli/test_issues_list_json.py—test_issues_list_human_missing_issue_exits_non_zerotests/cli/test_miner_commands.py—TestPatCheckAggregateCounts(imports_pat_check_aggregate_countsfrom minerhelpers)Migration notes (miner check JSON)
invalidwithno_pat+invalid_pat, or derive fromresults.no_responsestill means rows classified as no response (including cases that do not match the other three categories).Test plan