fix: count old open mirror issues for issue spam multiplier#930
Open
MkDev11 wants to merge 7 commits intoentrius:testfrom
Open
fix: count old open mirror issues for issue spam multiplier#930MkDev11 wants to merge 7 commits intoentrius:testfrom
MkDev11 wants to merge 7 commits intoentrius:testfrom
Conversation
c9dd095 to
173074e
Compare
173074e to
097f26e
Compare
Collaborator
|
Still debating on merging this — putting a pin in it. |
Contributor
Author
|
thanks @anderdc , totally understand you. My only push for merging is that this is the exact follow-up called out in #796: scoring should stay lookback-bounded, but the open-issue spam count should be current open issue load. The PR keeps the scoring fetch unchanged. It only separates If the concern is the temporary second mirror request, I can drop that fallback and only wire the future field, but that would leave #929 unfixed until the mirror serves it. |
10 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits mirror issue-discovery scoring from open-issue spam counting.
The scoring path still uses the lookback-bounded mirror
/issuesresponse, buttotal_open_issuesis now resolved independently so older still-open issues count towardcalculate_open_issue_spam_multiplier().This also adds support for a future mirror
open_issue_countresponse field. Until the mirror serves that field, the validator falls back to a separate all-time current-open issue fetch and filters it to mirror-enabled repos.Related Issues
Fixes #929
Type of Change
Testing
Commands run:
Checklist