Increase request-response max log statement size for GCP#359
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the default request/response logging truncation limits for GCP to better utilize Cloud Logging’s per-entry size constraints while accounting for wrapper overhead.
Changes:
- Increase default
maxBodySizefor GCP logbook logging to 224 KiB (229,376 bytes). - Increase default
maxBodySizefor GCP gRPC request/response logging to 224 KiB (229,376 bytes). - Adjust configured
maxSizevalues and update inline documentation/comments to reflect the intended Cloud Logging limit.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
gcp/request-response-spring-boot-starter-gcp-grpc-spring/.../RequestResponseGcpGrpcSpringAutoConfiguration.java |
Raises default gRPC request/response body truncation limit for GCP. |
gcp/logbook-spring-boot-autoconfigure-gcp/.../LogbookGcpAutoConfiguration.java |
Raises default HTTP logbook body truncation limit for GCP. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docs: add max size documentation to guides for PR 359 Agent-Logs-Url: https://github.com/entur/cloud-logging/sessions/74545817-1849-4728-ac34-f3cd25df704f Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: skjolber <1031478+skjolber@users.noreply.github.com> Co-authored-by: Thomas Skjølberg <thomas.skjolberg@gmail.com>
olereidar
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Max size increased from about 130k to 230k for body.
LogEntrymax is 256k, but that includes various wrapping.A quick smoke-tests found that wrapping was about 2k, so 230k should be very much on the safe size.
TODO: legacy branch