Exponential decay when requests fail#136
Merged
testower merged 4 commits intoentur:masterfrom Jan 8, 2024
Merged
Conversation
Collaborator
|
Thanks for your contribution @hbruch! Regarding your questions, I think they are relevant when design the v2 loader api. I would very much like to discuss this with you when I get there. The UpdateStrategy will probably be continued in v2, but then as a public api, so that the strategy can be tweaked by the library user if desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses entur/lamassu#340. It introduces an
UpdateStrategywhich schedules new requests depending on the number of previously failed request attempts, with a max delay of one hour.To verify this behaviour, a unit tests is added, which asserts that immediately after a failing request the feed should not update. Note that this is a rather implicit blackbox test. I considered extracting
UpdateStrategyto a proper class instead of a private nested class to do a whitebox test, but refrained from this asGBFSFeedUpdateris a private inner class also.Note further, that I came across two questions regarding the current implementation, which probably should be addressed in another PR (or need not, depending on the current reasoning).