Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for loading GBFS v3.0 feeds (currently 3.0-RC2). There are some API changes, so this leads to a major version bump.
GbfsSubscriptionManager, being the main entrypoint of the library, now has two subscription factory methods, one for < v3.x and one for 3.x. Library users will have to know the (major) version of the feed they are subscribing to up front, and the consumer will get the version specific model from gbfs-java-model.
GbfsLoader now has factory methods for version-specifc loader classes.
Mapping between versions must be done after consuming.
Note that support for loading multiple systems from manifest.json is not part of this PR.