Skip to content

Guard NetexId.createFrom against null valuePart#243

Merged
skjolber merged 2 commits intonetexIdUtilEquivalentfrom
copilot/sub-pr-242
Mar 20, 2026
Merged

Guard NetexId.createFrom against null valuePart#243
skjolber merged 2 commits intonetexIdUtilEquivalentfrom
copilot/sub-pr-242

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 20, 2026

NetexId.createFrom was silently converting a null valuePart to the literal string "null" via Java string concatenation, producing an invalid ID without any indication of the error.

Changes

  • NetexId.createFrom: Added Objects.requireNonNull(valuePart, "valuePart") as a precondition check, failing fast with a NullPointerException instead of emitting a malformed ID.
  • NetexIdTest: Added createFrom_whenNullValuePart_thenThrowNullPointerException to assert the null guard.
// Before: silently returned "XXX:FareContract:null"
NetexId.createFrom("XXX:FareContract:a", null);

// After: throws NullPointerException immediately
NetexId.createFrom("XXX:FareContract:a", null); // → NullPointerException

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Copilot AI changed the title [WIP] [WIP] Address comments from review on NetexId utility implementation Guard NetexId.createFrom against null valuePart Mar 20, 2026
Copilot AI requested a review from skjolber March 20, 2026 23:17
@skjolber skjolber marked this pull request as ready for review March 20, 2026 23:19
@skjolber skjolber merged commit 264503b into netexIdUtilEquivalent Mar 20, 2026
1 check passed
@skjolber skjolber deleted the copilot/sub-pr-242 branch March 20, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants