Guard NetexId.createFrom against null valuePart#243
Merged
skjolber merged 2 commits intonetexIdUtilEquivalentfrom Mar 20, 2026
Merged
Guard NetexId.createFrom against null valuePart#243skjolber merged 2 commits intonetexIdUtilEquivalentfrom
skjolber merged 2 commits intonetexIdUtilEquivalentfrom
Conversation
Co-authored-by: skjolber <1031478+skjolber@users.noreply.github.com> Agent-Logs-Url: https://github.com/entur/netex-utils/sessions/3f77131e-18b7-42cd-ac26-f9e31c020c12
Copilot
AI
changed the title
[WIP] [WIP] Address comments from review on NetexId utility implementation
Guard NetexId.createFrom against null valuePart
Mar 20, 2026
skjolber
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetexId.createFromwas silently converting a nullvaluePartto the literal string"null"via Java string concatenation, producing an invalid ID without any indication of the error.Changes
NetexId.createFrom: AddedObjects.requireNonNull(valuePart, "valuePart")as a precondition check, failing fast with aNullPointerExceptioninstead of emitting a malformed ID.NetexIdTest: AddedcreateFrom_whenNullValuePart_thenThrowNullPointerExceptionto assert the null guard.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.