Skip to content

Fix root/ files under dot-prefixed dirs not installed from GitHub URLs#51

Merged
hyericlee merged 1 commit into
mainfrom
fix-root-github-install
Apr 10, 2026
Merged

Fix root/ files under dot-prefixed dirs not installed from GitHub URLs#51
hyericlee merged 1 commit into
mainfrom
fix-root-github-install

Conversation

@hyericlee
Copy link
Copy Markdown
Contributor

@hyericlee hyericlee commented Apr 10, 2026

Summary

  • Fixes root/ directory files not installed when package is installed from GitHub URL #43root/ directory files containing dot-prefixed path segments (e.g. root/.opencode/plugins/qmd-hooks.ts) were silently skipped when installing from a GitHub URL, but worked from local paths
  • Root cause: minimatch(path, "**") returns false for paths with dot-prefixed segments (like .opencode/) unless {dot: true} is passed. GitHub installs set matchedPattern = "**" via computePathScoping; local installs never set it, so the filter was inactive
  • Introduces a centralized matchPackagePath utility that wraps minimatch with {dot: true} and replaces bare minimatch() at all 4 affected call sites

@hyericlee hyericlee closed this Apr 10, 2026
@hyericlee hyericlee deleted the fix-root-github-install branch April 10, 2026 03:25
@hyericlee hyericlee restored the fix-root-github-install branch April 10, 2026 03:26
@hyericlee hyericlee reopened this Apr 10, 2026
@hyericlee hyericlee merged commit 122f776 into main Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

root/ directory files not installed when package is installed from GitHub URL

1 participant