Wrong exit code if apply fails because of wrong parameters

[markussiebert]

Hi,

i use stack_master in our gitlab-ci environment a lot. One thing I think is not good is the exit code of the apply command, if there are empty/blanc parameters.

$ bundle exec stack_master apply tst sfn-seec--tst--default--base -y
Executing apply on sfn-seec--tst--default--base in eu-central-1
Stack diff: No changes
**Empty/blank parameters detected, ensure values exist for those parameters. Parameters will be read from the following locations:**
 - /builds/Free4All/SparkleformationPacks/sfn_seec_base/generic/parameters/tst/sfn_seec__tst__default__base.yml
Parameters diff: 
+---
.... my parameters


**No stack found**
$ bundle exec stack_master delete tst sfn-seec--tst--default--base -y
Stack does not exist
Job succeeded

So i think this should fail.

[patrobinson]

Sorry what is the exit code and what do you expect it to be?

[markussiebert]

For example here is one CF Parameter missing:

$ bundle exec stack_master apply "$ENVIRONMENT-$UNIQUE_IDENTIFIER" "$APPLICATION_NAME--$ENVIRONMENT--$UNIQUE_IDENTIFIER--service-$SERVICE" --config "stack_master_$ENVIRONMENT-$UNIQUE_IDENTIFIER.yml" -y --trace
Executing apply on blablabla-1
Stack diff: No changes
Empty/blank parameters detected, ensure values exist for those parameters. Parameters will be read from the following locations:
 - /home/markus/ ....
Parameters diff:
...

Build succeeded
markus@Markus-VirtualBox:~...$ echo $?
0

The exit code is 0 but there was an error - an empty or blanc parameter. So the stack_master apply command should return 1 instead

[markussiebert]

The same for:

bundle exec stack_master delete tst sfn-seec--tst--default--base -y
Stack does not exist
Job succeeded

if the stack was not found, it should return 1 instead of 0 because the execution was not possible

[markussiebert]

Ok, changing the behavior of apply was easy - but changing delete is tricky, because you call this method not the way you do for other commands

[markussiebert]

im working on an mr for this