Support the yaml extension for parameter files#203
Merged
patrobinson merged 5 commits intomasterfrom Feb 21, 2018
Merged
Conversation
patrobinson
changed the title
viraptor
approved these changes
Dec 14, 2017
| File.join(base_dir, 'parameters', a, "#{underscored_stack_name}.yml") | ||
| [ | ||
| File.join(base_dir, 'parameters', a, "#{underscored_stack_name}.yml"), | ||
| File.join(base_dir, 'parameters', a, "#{underscored_stack_name}.yaml"), |
Contributor
There was a problem hiding this comment.
Does this merge both contents, or does it prefer yml? (and should that be documented somewhere?)
Contributor
Author
There was a problem hiding this comment.
Good suggestion, it prefers yml now and it's documented and tested
added 2 commits
December 14, 2017 13:43
Prefer yml files over yaml files Create tests to ensure the behaviour is consistent
stevehodgkiss
approved these changes
Dec 15, 2017
| File.join(base_dir, 'parameters', "#{underscored_stack_name}.yaml"), | ||
| File.join(base_dir, 'parameters', "#{underscored_stack_name}.yml"), | ||
| ] | ||
| end |
Contributor
There was a problem hiding this comment.
Wondering if we should rename these methods to _paths?
Contributor
Author
There was a problem hiding this comment.
I've refactored the repetitive bit out. Most of the time we'd only return one path now as it's using a Glob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.