Skip to content

Feature/bugfix return codes #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markussiebert wants to merge 4 commits into from
Closed

Feature/bugfix return codes #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e22cf71
bugfix of exit codes for failed stack commands
markussiebert Feb 1, 2019
9f75fa1
reverted version number
markussiebert Feb 1, 2019
8ba5589
changed validate cucumber test
markussiebert Feb 1, 2019
b707454
reverted cucumber test for validate
markussiebert Feb 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/stack_master/cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ def execute!
stack_name = Utils.underscore_to_hyphen(args[1])

StackMaster.cloud_formation_driver.set_region(region)
StackMaster::Commands::Delete.perform(region, stack_name)
StackMaster::Commands::Delete.perform(region, stack_name).success?
end
end

Expand Down
2 changes: 1 addition & 1 deletion lib/stack_master/commands/apply.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def ensure_valid_parameters!
@stack_definition.parameter_files.each do |parameter_file|
StackMaster.stderr.puts " - #{parameter_file}"
end
halt!
failed!
end
end

Expand Down
2 changes: 1 addition & 1 deletion lib/stack_master/commands/delete.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def initialize(region, stack_name)

def perform

return unless check_exists
failed! unless check_exists

unless ask?("Really delete stack #{@stack_name} (y/n)? ")
StackMaster.stdout.puts "Stack update aborted"
Expand Down