no need for explicit exit since bin/stack_master already handles that#280
no need for explicit exit since bin/stack_master already handles that#280patrobinson merged 2 commits intoenvato:masterfrom
Conversation
patrobinson
left a comment
patrobinson
left a comment
There was a problem hiding this comment.
I want to add some integration tests for validate as well since that's been having issues
| When I run `stack_master apply foo bar` | ||
| Then the output should contain "Could not find stack definition bar in region foo" | ||
| And the exit status should be 1 | ||
| And the exit status should be 0 |
There was a problem hiding this comment.
Wouldn't this be 1 based on if stack_definitions.empty? ... success = false ?
There was a problem hiding this comment.
it would be 1 if success returns false, because exit !!false in bin/stack_master.rb
There was a problem hiding this comment.
it will never be 1 since we do not run bin/stack_master in this test, which includes the exit
There was a problem hiding this comment.
I think we should just remove this test rather than introduce something that tests for undesirable behaviour.
There was a problem hiding this comment.
then it should be removed from all of them for consistency 🤷♂️
There was a problem hiding this comment.
While the other tests are not accurate they do reflect the behaviour we want to see.
This test is both inaccurate and does not reflect true behaviour
|
tests for |
logingood
left a comment
logingood
left a comment
There was a problem hiding this comment.
👍
can we get it merged sooner, otherwise our jenkins builds are broken :(
Co-Authored-By: grosser <michael@grosser.it>
|
updated |
|
Released as 1.13.1 |
3 participants
followup to #276 which fixed 1 bug and introduced another 😨
the cucumber test was misleading since it never executes bin/stack_master and so never gets the actual exit status
also simplifying by converting the array logic to a boolean
replaces #279
fixes #277
fixes #278