Skip to content

Require sparkle_formation version 3#307

Merged
orien merged 1 commit intomasterfrom
sparkle_formation_version
Mar 4, 2020
Merged

Require sparkle_formation version 3#307
orien merged 1 commit intomasterfrom
sparkle_formation_version

Conversation

@orien
Copy link
Copy Markdown
Member

@orien orien commented Mar 3, 2020

I came across the following error while running the latest stack_master in conjunction with an old version of sparkle_formation.

StackMaster::TemplateCompiler::TemplateCompilationFailed Failed to compile <redacted>.rb with error undefined method `apply' for #<SparkleFormation::SparkleCollection:0x00007f9118c8d808>

I found stack_master is incompatible with older versions: the RSpec suite doesn't pass with any version before 3.0.0.

Limit sparkle_formation to any 3.x.x version.

stack_master is incompatible with older versions
Copy link
Copy Markdown
Contributor

@patrobinson patrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be better at pinning the versions in gemspec.
Thanks

@orien orien merged commit 99b4560 into master Mar 4, 2020
@orien orien deleted the sparkle_formation_version branch March 4, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants