feat: add search bar to external account list #1909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend
|
||||||||||||||||||||||||||||
| Project |
frontend
|
| Branch Review |
search-accounts
|
| Run status |
|
| Run duration | 01m 42s |
| Commit |
|
| Committer | Fynn Heintz |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
35
|
| View all changes introduced in this branch ↗︎ | |
Member
|
Looks good, but I would prefer the placeholder text in the search bar to be a lighter color. Right now, it looks like it's already pre-filled with that text.
|
Contributor
Author
|
@morremeyer afaik this is a browser default. We are not explicitly setting any color there. |
morremeyer
approved these changes
Mar 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
Screenshot for release notes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1503