Skip to content

Conversation

@JonoPrest
Copy link
Collaborator

Will only work once this is merged and released:

enviodev/hypersync-client-rust#66

@JonoPrest JonoPrest requested a review from JasoonS May 13, 2025 12:36
cargotree Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this type of file - do we want this committed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, didn't mean to commit. Was just looking at the cargo tree to figure out which packages were causing dependency clashes. Will remove

@JasoonS
Copy link
Contributor

JasoonS commented May 14, 2025

I believe merging this will break these docs: https://enviodev.github.io/hypersync-client-node/

@JasoonS
Copy link
Contributor

JasoonS commented May 14, 2025

Will revert that. Otherwise I think this looks fine as a start.

@JonoPrest
Copy link
Collaborator Author

@JasoonS I've fixed it, I simply ran the yarn docs script but it was configured to use markdown plugin. I changed it to just use the basic one and now it generated html

@JonoPrest JonoPrest merged commit 176dbfa into main May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants