test: replace advanceTimeAsync with advanceTimeAndRun#13122
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Sep 16, 2020
Merged
test: replace advanceTimeAsync with advanceTimeAndRun#13122mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Antonio Vicente <avd@google.com>
antoniovicente
requested review from
alyssawilk and
mattklein123
as code owners
mattklein123
approved these changes
Sep 16, 2020
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Nice cleanup! Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: test: replace advanceTimeAsync with advanceTimeAndRun
Additional Description:
Following up from #12609 (comment)
Risk Level: n/a, test only changes
Testing: n/a test API changes
Docs Changes: n/a
Release Notes: n/a
/cc @mattklein123