always use randomly generated stream id #1878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shriram Rajagopalan <shriram@us.ibm.com>
| uint64_t ConnectionManagerUtility::generateStreamId(const Router::Config& route_table, | ||
| Runtime::RandomGenerator& random_generator) { | ||
| // See the comment for next_stream_id_ in conn_manager_utility.h for why we do this. | ||
| if (route_table.usesRuntime()) { |
Member
There was a problem hiding this comment.
Please remove all traces of usesRuntime()
added 2 commits
October 17, 2017 15:22
…ndom Signed-off-by: Shriram Rajagopalan <shriram@us.ibm.com>
Signed-off-by: Shriram Rajagopalan <shriram@us.ibm.com>
htuch
approved these changes
Oct 17, 2017
mattklein123
approved these changes
Oct 17, 2017
Member
|
OS X failures is the unrelated |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Some ASAN and TSAN builds require a local JDK (https://github.com/envoyproxy/envoy-mobile/pull/1870/checks?check_run_id=3874356472) so we add them to those workflows Risk Level: Low Testing: See asan and tsan checks Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Some ASAN and TSAN builds require a local JDK (https://github.com/envoyproxy/envoy-mobile/pull/1870/checks?check_run_id=3874356472) so we add them to those workflows Risk Level: Low Testing: See asan and tsan checks Docs Changes: N/A Release Notes: N/A Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1812 fixed the perf issues with random number generation. We no longer have to rely on monotonically increasing stream IDs for perf reasons. Switch to always using randomly generated stream IDs.
Signed-off-by: Shriram Rajagopalan shriram@us.ibm.com