docs: Fix Deprecated Tap Request Examples

[DavidPeet8]

Commit Message:
Update the Tap documentation to avoid use of match_config as this is deprecated and use of this field causes errors in CI.

Signed-off-by: David Peet davidpeet@tutanota.com

Additional Description: n/a
Risk Level: low
Testing: n/a
Docs Changes: Update documentation for Tap filter to use match instead of match_config
Release Notes: n/a
Platform Specific Features: n/a
Fixes: #20190

[repokitteh-read-only]

Hi @DavidPeet8, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #20194 was opened by DavidPeet8.

see: more, trace.

[rojkov]

/assign @yangminzhu

[phlax]

with these inline configs that tend to go stale - i generally ask/recommend that we move them into separate yaml files so that they are tested

i would be happy to follow up tho, if we just fix them in this pr

[phlax]

...or advise on how to do so

[DavidPeet8]

i generally ask/recommend that we move them into separate yaml files so that they are tested

@phlax Is that testing automatic or is the thought that separate yaml files for these code snippets will make developers more likely to test them as they are more obvious? If these tests are automatic, are there any additional changes I need to make to set them up?

[phlax]

testing is automatic - if you grep for literalinclude you will find other examples of config that has been separated out to full (bootstrap) configs

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[phlax]

hi @DavidPeet8 would be good to progress this

copying out the error (config validation)

ERROR: some configuration files (1) failed to validate

ERROR (validation failed): docs/root/configuration/http/http_filters/_include/tap-filter.yaml
Failed to parse static_resources field: Failed to parse listeners field: Failed to parse filter_chains field: Failed to parse filters field: Failed to parse http_filters field: Failed to parse common_config field: Message type "envoy.extensions.common.tap.v3.AdminConfig" has no field named "tap_config".
 Available Fields(except extensions): ['configId']......

[DavidPeet8]

Hi @phlax I won't have much capacity to look into the validation errors on the documents for a few weeks. Is it alright if I return to this then?

[phlax]

Is it alright if I return to this then?

sure, of course, lmk if i can help resolving the remaining issues

/wait

[DavidPeet8]

Hey @phlax - just an FYI, I'm an intern at Uber right now and my term ends at the end of next week. At that point I'll lose access to my dev environment for Envoy. I'm not sure if I'll have the time to look into why the docs are failing builds before then, so feel free to commandeer this change to get it in.

[github-actions]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

[github-actions]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!