thrift: Explicitly express no cluster header for weighted clusters #20679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com>
Contributor
|
Contributor
|
In file included from source/extensions/filters/network/thrift_proxy/router/router_impl.cc:1: |
Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com>
zuercher
approved these changes
Apr 11, 2022
vehre-x41
pushed a commit
to vehre-x41/envoy
that referenced
this pull request
Apr 19, 2022
…nvoyproxy#20679) Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com> Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…nvoyproxy#20679) Risk Level: low Testing: n/a Docs Changes: n/a Release Notes: n/a Signed-off-by: kuochunghsu <kuochunghsu@pinterest.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuochunghsu kuochunghsu@pinterest.com
Commit Message:
The is a followup from #20577 (comment)
return parent_->ClusterHeader()hints we might have a header to honor, which is not true.