build: Add bazel option for enabling Universal Header Validator #20845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yan Avlasov <yavlasov@google.com>
zuercher
approved these changes
Apr 15, 2022
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
lgtm -- probably wait till post release to merge since this doesn't seem to have any effect yet?
Contributor
Author
@zuercher when is the release? There are a couple of PRs blocked by this. |
Member
|
Happening now. |
Contributor
Author
|
Merging since release was completed, for Monday work. |
vehre-x41
pushed a commit
to vehre-x41/envoy
that referenced
this pull request
Apr 19, 2022
…20845) Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…20845) Signed-off-by: Yan Avlasov <yavlasov@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Description:
This config setting enables Universal Header Validator and disables HTTP header compliance checks in codecs.
This setting is temporary to transition header validation into UHV without impacting production builds of Envoy.
This setting is enabled for the bazel.compile_time_options CI target.
Risk Level: Low, build options for compile_time_options CI target
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Part of #20261
Signed-off-by: Yan Avlasov yavlasov@google.com