doc: add size_t discussion to style guide, and correct OptRef doc#23982
Merged
jmarantz merged 2 commits intoenvoyproxy:mainfrom Nov 18, 2022
Merged
doc: add size_t discussion to style guide, and correct OptRef doc#23982jmarantz merged 2 commits intoenvoyproxy:mainfrom
jmarantz merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
zuercher
approved these changes
Nov 14, 2022
Member
|
@jmarantz not sure if you wanted shop this around to more maintainers or just merge |
Contributor
Author
|
I can shop around more. I think this is just codifying what we've been doing some in reviews, but maybe not 100% consistently . I did bring this up on slack. I'll wait a few more days before merging; not sure if everyone saw the slack. @envoyproxy/envoy-maintainers WDYT? |
ggreenway
approved these changes
Nov 15, 2022
yanavlasov
approved these changes
Nov 16, 2022
adisuissa
approved these changes
Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: add a discussion about size_t vs uint64_t to the style guide.
Additional Description: This was discussed during reviews, but not called out in the style guide.
Risk Level: low
Testing: none
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a