build: Adds a envoy_select_signal_trace Bazel macro#27155
build: Adds a envoy_select_signal_trace Bazel macro#27155abeyad merged 9 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Ali Beyad <abeyad@google.com>
Signed-off-by: Ali Beyad <abeyad@google.com>
Signed-off-by: Ali Beyad <abeyad@google.com>
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
Looks great! Thanks for doing this. A couple of minor questions.
| # Selects the given values if signal trace is enabled in the current build. | ||
| def envoy_select_signal_trace(xs, repository = ""): | ||
| return select({ | ||
| repository + "//bazel:disable_signal_trace": [], |
There was a problem hiding this comment.
Shall we add the mobile-specific logic here too, or do you want to do so in a followup?
There was a problem hiding this comment.
Actually, we can't add the mobile targets b/c disable_signal_trace is already set via .bazelrc and on CI.
(discussed this with Ryan offline)
So I reverted the change and put it back to the original.
| }), | ||
| ] + envoy_select_signal_trace( | ||
| ["@envoy//source/common/signal:sigaction_lib"], | ||
| "@envoy", |
There was a problem hiding this comment.
Indeed it is, for the reasons mentioned above
Signed-off-by: Ali Beyad <abeyad@google.com>
Signed-off-by: Ali Beyad <abeyad@google.com>
|
/retest |
|
Retrying Azure Pipelines: |
Signed-off-by: Ali Beyad <abeyad@google.com>
|
added @keith for cross-company review |
Signed-off-by: Ali Beyad <abeyad@google.com>
.bazelrc
Outdated
| build:remote --google_default_credentials=true | ||
| build:remote --remote_download_toplevel | ||
| build:remote --nobuild_runfile_links | ||
| # build:remote --nobuild_runfile_links |
There was a problem hiding this comment.
undid this just now, sorry for the confusion! i was just trying out undoing a phlax change that was causing CI to fail. phlax is going to send in a fix for it tomorrow. thanks for reviewing!
Signed-off-by: Ali Beyad <abeyad@google.com>
|
Now that phlax's PR has landed, I think this just needs a main merge. |
Signed-off-by: Ali Beyad <abeyad@google.com>
Signed-off-by: Ali Beyad <abeyad@google.com> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
3 participants
No description provided.