stats: revert "Prom stats perf improvements"#27226
Merged
jmarantz merged 1 commit intoenvoyproxy:mainfrom May 6, 2023
Merged
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
@rulex123 fyi |
Contributor
Author
|
I'd suggest only merging this if someone can post an actual repro to the attached bug. |
Member
|
This is a major regression, should revert first. |
kyessenov
approved these changes
May 6, 2023
Contributor
kyessenov
left a comment
kyessenov
left a comment
There was a problem hiding this comment.
Revert to root cause without the time pressure.
reskin89
pushed a commit
to reskin89/envoy
that referenced
this pull request
Jul 11, 2023
Commit Message: Reverts envoyproxy#24998 See envoyproxy#27173 Additional Description: Risk Level: n/a Testing: n/a Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Reverts #24998
See #27173
Additional Description:
Risk Level: n/a
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a