Skip to content

Conversation

@wbpcode
Copy link
Member

@wbpcode wbpcode commented Oct 24, 2023

Commit Message: remove expired runtime flag: envoy.reloadable_features.validate_detailed_override_host_statuses
Additional Description:

To close #29103.

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

…led_override_host_statuses

Signed-off-by: wbpcode <wbphub@live.com>
@wbpcode wbpcode requested a review from yanavlasov October 24, 2023 06:55
@repokitteh-read-only
Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #30446 was opened by wbpcode.

see: more, trace.

Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

baffled as to why this doesn't need main merge for the other flag update but if it works it works :-)

@alyssawilk alyssawilk merged commit 3f73002 into envoyproxy:main Oct 24, 2023
@wbpcode wbpcode deleted the dev-remove-runtime-upstream branch October 24, 2023 13:04
@TAOXUY
Copy link
Contributor

TAOXUY commented Nov 3, 2023

Hi @wbpcode , removing this flag makes this flow(call route() in log() time when localReply is called before and route isn't inited) won't work anymore. Could you shed some light on how to this issue?

@wbpcode
Copy link
Member Author

wbpcode commented Nov 4, 2023

@TAOXUY are you sure that it's this patch that effect your flow?

This is only for a upstream host statues validation.

@wbpcode
Copy link
Member Author

wbpcode commented Nov 4, 2023

We do removed a related flag in the #30444. But it only effects the Envoy 1.29+ (note the 1.29 still in the development phase). And the bug that you noticed in the #28626 should has been fixed by #28875. That fix patch is already available in the Envoy 1.28.

@TAOXUY
Copy link
Contributor

TAOXUY commented Nov 5, 2023

Thanks for the quick response! We will check after upgrading to 1.28.

@wbpcode
Copy link
Member Author

wbpcode commented Nov 6, 2023

Then any new reporting would be appreciated. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

envoy_reloadable_features_validate_detailed_override_host_statuses deprecation

3 participants