cares: restoring prior defaults#35335
Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom Jul 23, 2024
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
@yanavlasov I'm not sure what the function of dependency shephard review is if not to catch this sort of thing. |
mattklein123
approved these changes
Jul 22, 2024
martinduke
pushed a commit
to martinduke/envoy
that referenced
this pull request
Aug 8, 2024
This should theoretically restore the defaults changed in https://github.com/c-ares/c-ares/pull/542/files Risk Level: medium Testing: Docs Changes: n/a Release Notes: n/a fixes envoyproxy#35117 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Martin Duke <martin.h.duke@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should theoretically restore the defaults changed in https://github.com/c-ares/c-ares/pull/542/files
Risk Level: medium
Testing:
Docs Changes: n/a
Release Notes: n/a
fixes #35117