socket: Add network namespace parameter to SocketAddress proto#38945
socket: Add network namespace parameter to SocketAddress proto#38945zuercher merged 3 commits intoenvoyproxy:mainfrom
Conversation
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
The new field is not implemented and hidden. Signed-off-by: Tony Allen <txallen@google.com>
tonya11en
force-pushed
the
tallen/netns_socket
branch
from
acde072 to
765db5b
Compare
|
/retest |
tonya11en
changed the title
Signed-off-by: Tony Allen <txallen@google.com>
|
/retest |
|
@botengyao / @yanavlasov you are required reviewers on this, since you're code owners. |
| bool ipv4_compat = 6; | ||
|
|
||
| // The Linux network namespace to bind the socket to. If this is set, Envoy will | ||
| // create the socket in the specified network namespace. Only supported on Linux. |
There was a problem hiding this comment.
Is there any format requirement for the network namespace file path we should follow, e.g., /proc/<pid>/ns/net? Maybe add more comments?
There was a problem hiding this comment.
Please also take into account named network namespaces, which are solved via bind mounts to /var/run/netns/<name>
There was a problem hiding this comment.
I'll have to follow this PR up with the implementation, so I'll beef up the comments with examples in the next patch.
|
Aha, apologies, and we have the Slack notifier for the @assignee not the reviewers. |
|
I think this is ok to merge with an api-shepherds approval and the rest. /assign-from @envoyproxy/senior-maintainers since Adi replied in the channel. |
|
@envoyproxy/senior-maintainers assignee is @zuercher |
5 participants
Extends SocketAddress to allow us to specify the network namespace of the socket. This is an API-only change and it is hidden, since there is no implementation.
Addresses #38947