lower quic coverage threshold #39157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ohadvano <49730675+ohadvano@users.noreply.github.com>
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
Contributor
Author
|
/assign @phlax |
Contributor
Author
|
Yes, I merged main and it still failed |
Contributor
Author
|
Seems flaky afterall |
Contributor
Author
|
Got this flakiness once again, reopening |
phlax
approved these changes
Apr 22, 2025
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
lgtm, thanks @ohadvano
cc @RyanTheOptimist @botengyao for signoff
botengyao
approved these changes
Apr 22, 2025
RyanTheOptimist
approved these changes
Apr 23, 2025
oconnorkyle
pushed a commit
to oconnorkyle/envoy
that referenced
this pull request
Apr 23, 2025
Additional Description: lowering quic coverage threshold due to https://github.com/envoyproxy/envoy/actions/runs/14514384782/job/40720069262. The PR does not change any source code line but seems like it triggers the coverage failure. @phlax Signed-off-by: ohadvano <49730675+ohadvano@users.noreply.github.com> Signed-off-by: Kyle O'Connor <oconnorkyle@google.com>
oconnorkyle
pushed a commit
to oconnorkyle/envoy
that referenced
this pull request
Apr 23, 2025
Additional Description: lowering quic coverage threshold due to https://github.com/envoyproxy/envoy/actions/runs/14514384782/job/40720069262. The PR does not change any source code line but seems like it triggers the coverage failure. @phlax Signed-off-by: ohadvano <49730675+ohadvano@users.noreply.github.com> Signed-off-by: Kyle O'Connor <oconnorkyle@google.com>
jtlisi
pushed a commit
to jtlisi/envoy
that referenced
this pull request
Apr 24, 2025
Additional Description: lowering quic coverage threshold due to https://github.com/envoyproxy/envoy/actions/runs/14514384782/job/40720069262. The PR does not change any source code line but seems like it triggers the coverage failure. @phlax Signed-off-by: ohadvano <49730675+ohadvano@users.noreply.github.com> Signed-off-by: Jacob Lisi <jtlisi@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Description: lowering quic coverage threshold due to https://github.com/envoyproxy/envoy/actions/runs/14514384782/job/40720069262. The PR does not change any source code line but seems like it triggers the coverage failure. @phlax