Skip to content

websocket: remove websocket switch protocol check runtime guard #39159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
botengyao merged 2 commits into from
Apr 18, 2025
Merged

websocket: remove websocket switch protocol check runtime guard #39159

botengyao merged 2 commits into from
Apr 18, 2025

Conversation

@botengyao
Copy link
Member

@botengyao botengyao commented Apr 17, 2025

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes:#38037

@botengyao
remove websocket switch protocol check
3e2bac5 
Signed-off-by: Boteng Yao <boteng@google.com>
@repokitteh-read-only
Copy link

repokitteh-read-only bot commented Apr 17, 2025

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #39159 was opened by botengyao.

see: more, trace.

@botengyao
Copy link
Member Author

botengyao commented Apr 17, 2025

/assign @adisuissa

adisuissa
adisuissa previously approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@botengyao
Copy link
Member Author

botengyao commented Apr 17, 2025

@adisuissa, need a new stamp due to merge conflict, thanks!

@botengyao botengyao merged commit 19b31db into envoyproxy:main Apr 18, 2025
25 checks passed
oconnorkyle pushed a commit to oconnorkyle/envoy that referenced this pull request Apr 23, 2025
@botengyao @oconnorkyle
websocket: remove websocket switch protocol check runtime guard (envo…
3b95082 
…yproxy#39159)

<!--
!!!ATTENTION!!!

If you are fixing *any* crash or *any* potential security issue, *do
not*
open a pull request in this repo. Please report the issue via emailing
envoy-security@googlegroups.com where the issue will be triaged
appropriately.
Thank you in advance for helping to keep Envoy secure.

!!!ATTENTION!!!

For an explanation of how to fill out the fields, please see the
relevant section
in
[PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md)
-->

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes:envoyproxy#38037

Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Kyle O'Connor <oconnorkyle@google.com>
oconnorkyle pushed a commit to oconnorkyle/envoy that referenced this pull request Apr 23, 2025
@botengyao @oconnorkyle
websocket: remove websocket switch protocol check runtime guard (envo…
8ce3db5 
…yproxy#39159)

<!--
!!!ATTENTION!!!

If you are fixing *any* crash or *any* potential security issue, *do
not*
open a pull request in this repo. Please report the issue via emailing
envoy-security@googlegroups.com where the issue will be triaged
appropriately.
Thank you in advance for helping to keep Envoy secure.

!!!ATTENTION!!!

For an explanation of how to fill out the fields, please see the
relevant section
in
[PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md)
-->

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes:envoyproxy#38037

Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Kyle O'Connor <oconnorkyle@google.com>
jtlisi pushed a commit to jtlisi/envoy that referenced this pull request Apr 24, 2025
@botengyao @jtlisi
websocket: remove websocket switch protocol check runtime guard (envo…
882f540 
…yproxy#39159)

<!--
!!!ATTENTION!!!

If you are fixing *any* crash or *any* potential security issue, *do
not*
open a pull request in this repo. Please report the issue via emailing
envoy-security@googlegroups.com where the issue will be triaged
appropriately.
Thank you in advance for helping to keep Envoy secure.

!!!ATTENTION!!!

For an explanation of how to fill out the fields, please see the
relevant section
in
[PULL_REQUESTS.md](https://github.com/envoyproxy/envoy/blob/main/PULL_REQUESTS.md)
-->

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes:envoyproxy#38037

Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Jacob Lisi <jtlisi@google.com>
@gheel-figma gheel-figma mentioned this pull request Jun 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adisuissa adisuissa adisuissa approved these changes

@tyxia tyxia Awaiting requested review from tyxia tyxia is a code owner

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

@yanavlasov yanavlasov Awaiting requested review from yanavlasov yanavlasov is a code owner

Assignees

@adisuissa adisuissa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@botengyao @adisuissa