Skip to content

Conversation

@yanavlasov
Copy link
Contributor

Adds support for matching requests that include the * character in the path. A relevant issue was created:
#39168
Risk Level:
Testing: Updated unit tests
Docs Changes: N/A
Release Notes: Added
Platform Specific Features: N/A
Runtime guard: envoy.reloadable_features.uri_template_match_on_asterisk

Resolves: #39168

@repokitteh-read-only
Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #39330 was opened by yanavlasov.

see: more, trace.

…ewrite and matching (envoyproxy#39169)

Adds support for matching requests that include the `*` character in the
path. A relevant issue was created:
envoyproxy#39168
Risk Level:
Testing: Updated unit tests
Docs Changes: N/A
Release Notes: Added
Platform Specific Features: N/A
Runtime guard: envoy.reloadable_features.uri_template_match_on_asterisk

Resolves: envoyproxy#39168

---------

Signed-off-by: Chwila <bartosz.chwila@sap.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @yanavlasov

@phlax phlax enabled auto-merge (rebase) May 5, 2025 17:10
@phlax
Copy link
Member

phlax commented May 5, 2025

/retest

@phlax phlax merged commit afa9f49 into envoyproxy:release/v1.33 May 5, 2025
11 checks passed
@yanavlasov yanavlasov deleted the pr39169-bp/v1.33 branch May 6, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants