Skip to content

Conversation

@wbpcode
Copy link
Member

@wbpcode wbpcode commented May 6, 2025

Commit Message: runtime: remove runtime envoy.reloadable_features.logging_with_fast_json_formatter
Additional Description:

#36629

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

…son_formatter

Signed-off-by: wangbaiping(wbpcode) <wbphub@gmail.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #39356 was opened by wbpcode.

see: more, trace.

@wbpcode
Copy link
Member Author

wbpcode commented May 7, 2025

/retest

@yanjunxiang-google
Copy link
Contributor

LGTM

@wbpcode
Copy link
Member Author

wbpcode commented May 9, 2025

friendly ping for an approval from @envoyproxy/senior-maintainers cc @yanavlasov

@wbpcode
Copy link
Member Author

wbpcode commented May 13, 2025

/retest

1 similar comment
@agrawroh
Copy link
Member

/retest

@wbpcode
Copy link
Member Author

wbpcode commented May 13, 2025

/retest

2 similar comments
@wbpcode
Copy link
Member Author

wbpcode commented May 13, 2025

/retest

@agrawroh
Copy link
Member

/retest

@wbpcode wbpcode merged commit ca8330a into envoyproxy:main May 14, 2025
25 checks passed
@wbpcode wbpcode deleted the dev-log-runtime branch May 14, 2025 00:39
fishpan1209 pushed a commit to fishpan1209/envoy that referenced this pull request May 22, 2025
…son_formatter (envoyproxy#39356)

Signed-off-by: Ting Pan <panting@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants