AddressObject to inherit from Address::InstanceAccessor #39680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the AddressObject class to inherit from Address::InstanceAccessor instead of StreamInfo::FilterState::Object. This change enhances the address handling capabilities while maintaining the existing functionality. This will allow to do CIDR range matching on AddressObject Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>
nezdolik
previously approved these changes
Jun 3, 2025
adisuissa
reviewed
Jun 3, 2025
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
/assign-from @envoyproxy/senior-maintainers
| public: | ||
| AddressObject(Network::Address::InstanceConstSharedPtr address) : address_(address) {} | ||
| AddressObject(Network::Address::InstanceConstSharedPtr address) | ||
| : Address::InstanceAccessor(address), address_(address) {} |
Contributor
There was a problem hiding this comment.
It seems that the address is now kept in 2 places: the address_ data member in AddressObject and the ip_ data member in InstanceAccessor.
I suggest ensuring ODR by only keeping the data member in InstanceAccessor.
Contributor
Author
There was a problem hiding this comment.
The address_ is now only store in InstanceAccessor but I add to create an additional method for InstanceAccessor to be able to share the InstanceConstSharedPtr
|
@envoyproxy/senior-maintainers assignee is @yanavlasov |
Contributor
|
/wait |
Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>
Signed-off-by: Florent Lecoultre <florent.lecoultre@datadoghq.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
yanavlasov
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the AddressObject class to inherit from
Address::InstanceAccessorinstead ofStreamInfo::FilterState::Object. This change enhances the address handling capabilities while maintaining the existing functionality. This will allow to do CIDR range matching on AddressObjectCommit Message: AddressObject to inherit from Address::InstanceAccessor
Additional Description: Updated the AddressObject class to inherit from Address::InstanceAccessor instead of StreamInfo::FilterState::Object. This change enhances the address handling capabilities while maintaining the existing functionality. This will allow to do CIDR range matching on AddressObject
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]