conn pool: added a new load shed when creating new connections to upstream #39685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boteng Yao <boteng@google.com>
…d_shed_point Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Boteng Yao <boteng@google.com>
botengyao
changed the title
Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Boteng Yao <boteng@google.com>
Member
Author
|
/assign @yanavlasov |
yanavlasov
reviewed
Jun 6, 2025
| return nullptr; | ||
| } else if (result == ConnectionResult::LoadShed) { | ||
| pending->cancel(Envoy::ConnectionPool::CancelPolicy::CloseExcess); | ||
| onPoolFailure(nullptr, absl::string_view(), ConnectionPool::PoolFailureReason::Overflow, |
Contributor
There was a problem hiding this comment.
Would it make sense to create a new failure reason so we can distinguish load shed from just pool limits overflow?
Member
Author
There was a problem hiding this comment.
Yes, I think that totally makes sense, and I tend to add an OverloadManager, but I realized that it will change a lot of other places that is associated with the enum, would you be okay to add a TODO that I will change it latter?
Signed-off-by: yanavlasov <yavlasov@google.com>
yanavlasov
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a load shed point when trying to create new connection in the connection pool.
Commit Message:
Additional Description:
Risk Level: low
Testing:
Docs Changes:
Release Notes: