add JuniorHsu as senior maintainer of thrift#41733
Merged
wbpcode merged 2 commits intoenvoyproxy:mainfrom Oct 28, 2025
Merged
Conversation
Signed-off-by: WangBaiping <wbphub@gmail.com>
Member
Author
|
cc @envoyproxy/envoy-maintainers |
JuniorHsu
reviewed
Oct 28, 2025
botengyao
previously approved these changes
Oct 28, 2025
Co-authored-by: Kuo-Chung Hsu <CuveeHsu@gmail.com> Signed-off-by: code <wbphub@gmail.com>
JuniorHsu
approved these changes
Oct 28, 2025
botengyao
approved these changes
Oct 28, 2025
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
Commit Message: add JuniorHsu as senior maintainer of thrift Additional Description: @JuniorHsu **is the only active contributor and also been code owner of thrift for a while.** Here is the contribution list from @JuniorHsu https://github.com/envoyproxy/envoy/pulls?q=is%3Apr+author%3AJuniorHsu+is%3Aclosed @JuniorHsu has submitted the highest number of Pull Requests in the Thrift domain to date. So, I suggest to add the @JuniorHsu as senior extension maintainer. :) NOTE: extension maintainer has no write permission but for extension in scope, the maintainers could treat the approval from extension maintainer as final decision. Of course, the maintainer may still need to take a look to ensure the PR changes is limited in the scope of specific extension and also ensure it's meet the basic code standards. Risk Level: low. Testing: n/a. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. --------- Signed-off-by: WangBaiping <wbphub@gmail.com> Signed-off-by: code <wbphub@gmail.com> Co-authored-by: Kuo-Chung Hsu <CuveeHsu@gmail.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: add JuniorHsu as senior maintainer of thrift
Additional Description:
@JuniorHsu is the only active contributor and also been code owner of thrift for a while. Here is the contribution list from @JuniorHsu https://github.com/envoyproxy/envoy/pulls?q=is%3Apr+author%3AJuniorHsu+is%3Aclosed @JuniorHsu has submitted the highest number of Pull Requests in the Thrift domain to date.
So, I suggest to add the @JuniorHsu as senior extension maintainer. :)
NOTE: extension maintainer has no write permission but for extension in scope, the maintainers could treat the approval from extension maintainer as final decision. Of course, the maintainer may still need to take a look to ensure the PR changes is limited in the scope of specific extension and also ensure it's meet the basic code standards.
Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.