dynamic_modules: add support for disabling HTTP per-route filter#42766
Merged
agrawroh merged 3 commits intoenvoyproxy:mainfrom Dec 24, 2025
Merged
dynamic_modules: add support for disabling HTTP per-route filter#42766agrawroh merged 3 commits intoenvoyproxy:mainfrom
agrawroh merged 3 commits intoenvoyproxy:mainfrom
Conversation
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
agrawroh
force-pushed
the
feat-dm-http-disabled
branch
from
d3bde3a to
babe5a5
Compare
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
agrawroh
force-pushed
the
feat-dm-http-disabled
branch
from
babe5a5 to
a5ef86d
Compare
mathetake
reviewed
Dec 24, 2025
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
mathetake
approved these changes
Dec 24, 2025
wbpcode
reviewed
Dec 25, 2025
Comment on lines
+123
to
+129
|
|
||
| // Disable the filter for this particular vhost or route. | ||
| // If this field is specified in multiple per-filter-configs, the most specific | ||
| // one will be used. | ||
| // | ||
| // If this field is not specified, the filter would remain enabled. | ||
| bool disabled = 4; |
Member
There was a problem hiding this comment.
I think we have provided common disabled flag in the route.v3.FilterConfig and it's not encouraged to add new disabled flag in new plugin.
And FWIW, the API need to be reviewed first before merge the PR.
wbpcode
added a commit
to wbpcode/envoy
that referenced
this pull request
Dec 25, 2025
…ter (envoyproxy#42766)" This reverts commit 1f516f1.
wbpcode
added a commit
that referenced
this pull request
Dec 25, 2025
…ter (#42766)" (#42771) Commit Message: Revert "dynamic_modules: add support for disabling HTTP per-route filter (#42766)" Additional Description: We have provided common disabled flag in the route configuration and this API may be unnecessary (and new api shepherd reviewed it. We need to revisit it before put int into our main. Risk Level: low. Testing: n/a. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a.
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
…oyproxy#42766) ## Description In this PR we are adding a new `disabled` flag to the per-route configuration for the dynamic modules HTTP filter which could be used to disable the dynamic modules on a per-route basis if needed. This matches the functionality we offer in other filters like ExtAuthZ, etc. --- **Commit Message:** dynamic_modules: add support for disabling HTTP per-route filter **Additional Description:** Added a new `disabled` flag to the per-route configuration for the dynamic modules HTTP filter which could be used to disable the dynamic modules on a per-route basis **Risk Level:** Low **Testing:** Added Tests **Docs Changes:** Added **Release Notes:** Added --------- Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com> Signed-off-by: Gustavo <grnmeira@gmail.com>
grnmeira
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Mar 20, 2026
…ter (envoyproxy#42766)" (envoyproxy#42771) Commit Message: Revert "dynamic_modules: add support for disabling HTTP per-route filter (envoyproxy#42766)" Additional Description: We have provided common disabled flag in the route configuration and this API may be unnecessary (and new api shepherd reviewed it. We need to revisit it before put int into our main. Risk Level: low. Testing: n/a. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. Signed-off-by: Gustavo <grnmeira@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR we are adding a new
disabledflag to the per-route configuration for the dynamic modules HTTP filter which could be used to disable the dynamic modules on a per-route basis if needed. This matches the functionality we offer in other filters like ExtAuthZ, etc.Commit Message: dynamic_modules: add support for disabling HTTP per-route filter
Additional Description: Added a new
disabledflag to the per-route configuration for the dynamic modules HTTP filter which could be used to disable the dynamic modules on a per-route basisRisk Level: Low
Testing: Added Tests
Docs Changes: Added
Release Notes: Added