-
Notifications
You must be signed in to change notification settings - Fork 5.2k
bazel: Add bzlmod compatibility layer for workspace mode #42938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
2623c85 to
18aa9c4
Compare
|
@copilot took a bit to get it working but docs now build correctly in bzlmod - however in doing it i broke workspace mode please fix and DONT BREAK bzlmod |
Fixed in commit 4941b93. The proto tooling now supports both workspace and bzlmod path patterns:
This resolves the undefined label warnings for xds.type.matcher.v3 messages in workspace mode while maintaining bzlmod compatibility. |
aff34e1 to
c705e6b
Compare
|
/retest macos transient |
i think we are the only ones that call it by that name, and with bzlmod doing so breaks our patches (for grpc) Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
c705e6b to
3285f11
Compare
Summary
Fixed the docs build error by adding bzlmod compatibility to the envoy_examples repository and proto tooling.
Changes Made
Cherry-picked bzlmod compatibility commit from copilot/fix-envoy-proto-descriptor branch
//bazel:bzlmod_modeconfig setting for conditional compilationenvoy) and bzlmod (_main) directory namesCreate and apply patch for envoy_examples repository
examples_docsgenrule to handle bzlmod canonical names (with~suffix)Fix proto documentation tooling for dual-mode support
external/com_github_cncf_xds/xds(workspace) andexternal/xds~(bzlmod)../com_github_cncf_xds(workspace) and../xds~(bzlmod)external/envoy(workspace) andexternal/_main(bzlmod)Testing
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.