Stop reading data immediately upon request in QUIC server stream.#43332
Merged
danzh2010 merged 2 commits intoenvoyproxy:mainfrom Feb 5, 2026
Merged
Stop reading data immediately upon request in QUIC server stream.#43332danzh2010 merged 2 commits intoenvoyproxy:mainfrom
danzh2010 merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Haoyue Wang <haoyuewang@google.com>
Contributor
Author
|
/assign @danzh2010 |
Signed-off-by: Haoyue Wang <haoyuewang@google.com>
danzh2010
reviewed
Feb 5, 2026
Contributor
danzh2010
left a comment
danzh2010
left a comment
There was a problem hiding this comment.
Please also update https://github.com/envoyproxy/envoy/blob/main/source/docs/quiche_integration.md#receive-buffer to reflect this optimization.
Contributor
Author
The feature is currently guarded by FALSE_RUNTIME_GUARD. Can we defer the documentation update after we test it in prod and change the guard to RUNTIME_GUARD? |
danzh2010
approved these changes
Feb 5, 2026
Contributor
Author
|
Thanks for the review! |
shane-yuan
pushed a commit
to shane-yuan/envoy
that referenced
this pull request
Feb 11, 2026
…voyproxy#43332) Commit Message: Stop reading data immediately upon request in QUIC server stream. Additional Description: When readDisable is called on EnvoyQuicServerStream, it is better for EnvoyQuicServerStream to not to deliver more data, which may cause more bytes buffered and more work. Risk Level: Low. Guarded by false runtime guard envoy.reloadable_features.quic_disable_data_read_immediately. --------- Signed-off-by: Haoyue Wang <haoyuewang@google.com>
copybara-service bot
pushed a commit
to google/quiche
that referenced
this pull request
Feb 19, 2026
Notes: 1. The comment next to QuicSpdyStreamBodyManager::Clear says "Since body is buffered by QuicStreamSequencer, this method should be called when QuicStreamSequencer frees up its buffers without reading." Since QuicStream::StopReading always clears the QuicStreamSequencer, QuicSpdyStreamBodyManager should always be cleared as well. 2. Seen from the new unit test, this change is akin to QUIC layer blocking being asynchronous and application layer blocking being synchronous in Envoy (since envoyproxy/envoy#43332) and thus is unlikely to be reproducible at GFE. Protected by FLAGS_quic_reloadable_flag_quic_clear_body_manager_along_with_sequencer. PiperOrigin-RevId: 872573565
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Stop reading data immediately upon request in QUIC server stream.
Additional Description: When readDisable is called on EnvoyQuicServerStream, it is better for EnvoyQuicServerStream to not to deliver more data, which may cause more bytes buffered and more work.
Risk Level: Low. Guarded by false runtime guard envoy.reloadable_features.quic_disable_data_read_immediately.