xds-failover: fix a corner case where initial-resource-versions is not populated#43876
Merged
ggreenway merged 2 commits intoenvoyproxy:mainfrom Mar 18, 2026
Conversation
…t populated Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Member
|
/assign @ggreenway |
paul-r-gall
approved these changes
Mar 17, 2026
Contributor
|
Waiting for senior maintainer review from @ggreenway |
ggreenway
approved these changes
Mar 17, 2026
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
…t populated (envoyproxy#43876) Fixing a case where the initial_resource_versions field in the delta-xDS discovery request isn't being populated correctly when xDS-Failover is used, and the primary doesn't respond on the first attempt. Risk Level: low - xDS-Failover is gated by an already existing `envoy.restart_features.xds_failover_support` and is still experimental. Testing: Added an integration test. Docs Changes: N/A Release Notes: Added. Platform Specific Features: N/A Signed-off-by: Adi Suissa-Peleg <adip@google.com>
TAOXUY
pushed a commit
to TAOXUY/envoy
that referenced
this pull request
Apr 1, 2026
…t populated (envoyproxy#43876) Fixing a case where the initial_resource_versions field in the delta-xDS discovery request isn't being populated correctly when xDS-Failover is used, and the primary doesn't respond on the first attempt. Risk Level: low - xDS-Failover is gated by an already existing `envoy.restart_features.xds_failover_support` and is still experimental. Testing: Added an integration test. Docs Changes: N/A Release Notes: Added. Platform Specific Features: N/A Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Xuyang Tao <taoxuy@google.com>
nshipilov
pushed a commit
to nshipilov/envoy
that referenced
this pull request
Apr 13, 2026
…t populated (envoyproxy#43876) Fixing a case where the initial_resource_versions field in the delta-xDS discovery request isn't being populated correctly when xDS-Failover is used, and the primary doesn't respond on the first attempt. Risk Level: low - xDS-Failover is gated by an already existing `envoy.restart_features.xds_failover_support` and is still experimental. Testing: Added an integration test. Docs Changes: N/A Release Notes: Added. Platform Specific Features: N/A Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Nick Shipilov <nick.shipilov.n@gmail.com>
kpramesh2212
pushed a commit
to kpramesh2212/envoy
that referenced
this pull request
Apr 14, 2026
…t populated (envoyproxy#43876) Fixing a case where the initial_resource_versions field in the delta-xDS discovery request isn't being populated correctly when xDS-Failover is used, and the primary doesn't respond on the first attempt. Risk Level: low - xDS-Failover is gated by an already existing `envoy.restart_features.xds_failover_support` and is still experimental. Testing: Added an integration test. Docs Changes: N/A Release Notes: Added. Platform Specific Features: N/A Signed-off-by: Adi Suissa-Peleg <adip@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: xds-failover: fix a corner case where initial-resource-versions is not populated
Additional Description:
Fixing a case where the initial_resource_versions field in the delta-xDS discovery request isn't being populated correctly when xDS-Failover is used, and the primary doesn't respond on the first attempt.
Risk Level: low - xDS-Failover is gated by an already existing
envoy.restart_features.xds_failover_supportand is still experimental.Testing: Added an integration test.
Docs Changes: N/A
Release Notes: Added.
Platform Specific Features: N/A