deps: Bump V8 13.8.258.26 -> 14.6.202.10, simdutf 7.3.4 -> 8.1.0, fp16#43928
Merged
jwendell merged 1 commit intoenvoyproxy:mainfrom Mar 12, 2026
Merged
deps: Bump V8 13.8.258.26 -> 14.6.202.10, simdutf 7.3.4 -> 8.1.0, fp16#43928jwendell merged 1 commit intoenvoyproxy:mainfrom
jwendell merged 1 commit intoenvoyproxy:mainfrom
Conversation
Member
|
dragonbox, highway and fast_float might also want to be updated - they were all picked/pinned to the version that v8 was using |
Member
Author
|
081c67e to
85c450c
Compare
Bump V8 to 14.6.202.10 which converts JSDispatchTable from per-IsolateGroup to per-Isolate (commit 4d1e2794e), eliminating the race condition in concurrent Isolate creation that caused crashes in Wasm VM cloning. Dependency updates required by V8 14.6: - simdutf 7.3.4 -> 8.1.0 (V8 now uses atomic simdutf functions) - fp16 updated to revision 3d2de1816 (matches V8 14.6 bundled version) Workarounds for LLVM 18 toolchain compatibility (all marked with TODO(jwendell) for removal once LLVM is bumped to 19+): - std::atomic_ref polyfill: LLVM 18's libc++ does not provide std::atomic_ref (C++20 P0019R8). V8 14.6 and simdutf use it pervasively. A polyfill header is injected into both V8 and simdutf via patches/patch_cmds using reinterpret_cast<std::atomic<T>*>. - consteval -> constexpr: clang 18 has bugs with consteval in certain template instantiation contexts (e.g. regexp-bytecodes-inl.h). All consteval occurrences in V8 are downgraded to constexpr, which is strictly more permissive and functionally safe. - ShuffleArray<>: clang 18 does not support default template argument deduction on alias templates without explicit <>. Other V8 14.6 patch updates: - Remove @libcxx//:libc++ from V8 deps (Envoy uses its own toolchain) - Remove -latomic linker flag - Add -Wno-invalid-offsetof, -Wno-dangling-pointer, -Wno-dangling-reference - Add macros.h to fp16.BUILD for new fp16 revision Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jonh Wendell <jwendell@redhat.com>
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
phlax
approved these changes
Mar 12, 2026
| "grep -rl 'std::atomic_ref' src/ include/ --include='*.h' --include='*.cc' | grep -v atomic_ref_polyfill | xargs -r sed -i '1s!^!#include \"src/base/atomic_ref_polyfill.h\"\\n!'", | ||
| # TODO(jwendell): Remove consteval->constexpr workaround once the LLVM toolchain is | ||
| # bumped. Clang 18 has bugs with consteval in template contexts (fixed in clang 19+). | ||
| "find ./src -type f \\( -name '*.h' -o -name '*.cc' \\) -exec sed -i 's/consteval/constexpr/g' {} \\;", |
Member
There was a problem hiding this comment.
these will be pain to rework in bzlmod - no patch_cmds
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
envoyproxy#43928) Bump V8 to 14.6.202.10 which converts JSDispatchTable from per-IsolateGroup to per-Isolate (commit 4d1e2794e), eliminating the race condition in concurrent Isolate creation that caused crashes in Wasm VM cloning. Dependency updates required by V8 14.6: - simdutf 7.3.4 -> 8.1.0 (V8 now uses atomic simdutf functions) - fp16 updated to revision 3d2de1816 (matches V8 14.6 bundled version) Workarounds for LLVM 18 toolchain compatibility (all marked with TODO(jwendell) for removal once LLVM is bumped to 19+): - std::atomic_ref polyfill: LLVM 18's libc++ does not provide std::atomic_ref (C++20 P0019R8). V8 14.6 and simdutf use it pervasively. A polyfill header is injected into both V8 and simdutf via patches/patch_cmds using reinterpret_cast<std::atomic<T>*>. - consteval -> constexpr: clang 18 has bugs with consteval in certain template instantiation contexts (e.g. regexp-bytecodes-inl.h). All consteval occurrences in V8 are downgraded to constexpr, which is strictly more permissive and functionally safe. - ShuffleArray<>: clang 18 does not support default template argument deduction on alias templates without explicit <>. Other V8 14.6 patch updates: - Remove @libcxx//:libc++ from V8 deps (Envoy uses its own toolchain) - Remove -latomic linker flag - Add -Wno-invalid-offsetof, -Wno-dangling-pointer, -Wno-dangling-reference - Add macros.h to fp16.BUILD for new fp16 revision Signed-off-by: Jonh Wendell <jwendell@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
fishcakez
pushed a commit
to fishcakez/envoy
that referenced
this pull request
Mar 25, 2026
envoyproxy#43928) Bump V8 to 14.6.202.10 which converts JSDispatchTable from per-IsolateGroup to per-Isolate (commit 4d1e2794e), eliminating the race condition in concurrent Isolate creation that caused crashes in Wasm VM cloning. Dependency updates required by V8 14.6: - simdutf 7.3.4 -> 8.1.0 (V8 now uses atomic simdutf functions) - fp16 updated to revision 3d2de1816 (matches V8 14.6 bundled version) Workarounds for LLVM 18 toolchain compatibility (all marked with TODO(jwendell) for removal once LLVM is bumped to 19+): - std::atomic_ref polyfill: LLVM 18's libc++ does not provide std::atomic_ref (C++20 P0019R8). V8 14.6 and simdutf use it pervasively. A polyfill header is injected into both V8 and simdutf via patches/patch_cmds using reinterpret_cast<std::atomic<T>*>. - consteval -> constexpr: clang 18 has bugs with consteval in certain template instantiation contexts (e.g. regexp-bytecodes-inl.h). All consteval occurrences in V8 are downgraded to constexpr, which is strictly more permissive and functionally safe. - ShuffleArray<>: clang 18 does not support default template argument deduction on alias templates without explicit <>. Other V8 14.6 patch updates: - Remove @libcxx//:libc++ from V8 deps (Envoy uses its own toolchain) - Remove -latomic linker flag - Add -Wno-invalid-offsetof, -Wno-dangling-pointer, -Wno-dangling-reference - Add macros.h to fp16.BUILD for new fp16 revision Signed-off-by: Jonh Wendell <jwendell@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump V8 to 14.6.202.10 which converts JSDispatchTable from per-IsolateGroup to per-Isolate (commit 4d1e2794e), eliminating the race condition in concurrent Isolate creation that caused crashes in Wasm VM cloning.
Dependency updates required by V8 14.6:
Workarounds for LLVM 18 toolchain compatibility (all marked with TODO(jwendell) for removal once LLVM is bumped to 19+):
std::atomic_ref polyfill: LLVM 18's libc++ does not provide std::atomic_ref (C++20 P0019R8). V8 14.6 and simdutf use it pervasively. A polyfill header is injected into both V8 and simdutf via patches/patch_cmds using reinterpret_cast<std::atomic*>.
consteval -> constexpr: clang 18 has bugs with consteval in certain template instantiation contexts (e.g. regexp-bytecodes-inl.h). All consteval occurrences in V8 are downgraded to constexpr, which is strictly more permissive and functionally safe.
ShuffleArray<>: clang 18 does not support default template argument deduction on alias templates without explicit <>.
Other V8 14.6 patch updates: