Skip to content

Nukes build_external#43931

Merged
mathetake merged 1 commit intoenvoyproxy:mainfrom
mathetake:trygazelle
Mar 12, 2026
Merged

Nukes build_external#43931
mathetake merged 1 commit intoenvoyproxy:mainfrom
mathetake:trygazelle

Conversation

@mathetake
Copy link
Copy Markdown
Member

@mathetake mathetake commented Mar 12, 2026

No description provided.

@mathetake
Nukes build_external
b7796ff 
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only Bot commented Mar 12, 2026

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #43931 was opened by mathetake.

see: more, trace.

@mathetake mathetake marked this pull request as ready for review March 12, 2026 20:03
@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Mar 12, 2026
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only Bot commented Mar 12, 2026

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @agrawroh

🐱

Caused by: #43931 was ready_for_review by mathetake.

see: more, trace.

@mathetake mathetake requested a review from phlax March 12, 2026 20:03
@mathetake mathetake marked this pull request as draft March 12, 2026 20:06
@mathetake
Copy link
Copy Markdown
Member Author

mathetake commented Mar 12, 2026

had a offline chat with @phlax - i need to do additional verification locally

@mathetake mathetake marked this pull request as ready for review March 12, 2026 20:18
@mathetake mathetake enabled auto-merge (squash) March 12, 2026 20:18
@mathetake
Copy link
Copy Markdown
Member Author

mathetake commented Mar 12, 2026

good to go

phlax
phlax approved these changes Mar 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mathetake

@mathetake mathetake merged commit cd11ab5 into envoyproxy:main Mar 12, 2026
28 of 29 checks passed
@mathetake mathetake deleted the trygazelle branch March 12, 2026 20:21
@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Mar 12, 2026
bmjask pushed a commit to bmjask/envoy that referenced this pull request Mar 14, 2026
@mathetake @bmjask
Nukes build_external (envoyproxy#43931)
76bab59 
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
fishcakez pushed a commit to fishcakez/envoy that referenced this pull request Mar 25, 2026
@mathetake @fishcakez
Nukes build_external (envoyproxy#43931)
7387072 
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
@phlax phlax mentioned this pull request Mar 25, 2026
Open
@phlax
Copy link
Copy Markdown
Member

phlax commented Mar 25, 2026

/backport

@repokitteh-read-only repokitteh-read-only Bot added the backport/review Request to backport to stable releases label Mar 25, 2026
phlax pushed a commit to phlax/envoy that referenced this pull request Apr 9, 2026
@mathetake @phlax
Nukes build_external (envoyproxy#43931)
32c6149 
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
phlax pushed a commit to phlax/envoy that referenced this pull request Apr 9, 2026
@mathetake @phlax
Nukes build_external (envoyproxy#43931)
1e4a739 
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request Apr 9, 2026
@mathetake @phlax
Nukes build_external (envoyproxy#43931)
84b10d8 
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
phlax pushed a commit to phlax/envoy that referenced this pull request Apr 9, 2026
@mathetake @phlax
Nukes build_external (envoyproxy#43931)
8ada0e4 
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request Apr 9, 2026
@mathetake @phlax
Nukes build_external (envoyproxy#43931)
098f500 
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit that referenced this pull request Apr 9, 2026
@phlax @mathetake
Nukes build_external (#43931) (#44353)
c10822b 
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Co-authored-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@phlax phlax removed the backport/review Request to backport to stable releases label Apr 10, 2026
krinkinmu pushed a commit to grnmeira/envoy that referenced this pull request Apr 20, 2026
@mathetake @krinkinmu
Nukes build_external (envoyproxy#43931)
d6d67aa 
Signed-off-by: Takeshi Yoneda <tyoneda@netflix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phlax phlax phlax approved these changes

Assignees

@agrawroh agrawroh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mathetake @phlax @agrawroh