dynamic_modules: add file watcher support for bootstrap dynamic modules#44139
Open
basundhara-c wants to merge 2 commits intoenvoyproxy:mainfrom
Open
dynamic_modules: add file watcher support for bootstrap dynamic modules#44139basundhara-c wants to merge 2 commits intoenvoyproxy:mainfrom
basundhara-c wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
…e extensions Add filesystem watcher API to the bootstrap extension ABI, mirroring the existing timer API. Modules can now watch files for MovedTo/Modified events on the main thread and receive callbacks via on_file_changed. Signed-off-by: Basundhara Chakrabarty <basundhara17061996@gmail.com>
basundhara-c
force-pushed
the
boostrap_dynamic_module_support_for_file_watch
branch
2 times, most recently
from
6ecbb77 to
2db49aa
Compare
Signed-off-by: Basundhara Chakrabarty <basundhara17061996@gmail.com>
basundhara-c
force-pushed
the
boostrap_dynamic_module_support_for_file_watch
branch
from
af814a8 to
9e6a041
Compare
basundhara-c
requested review from
agrawroh,
mathetake,
mattklein123 and
wbpcode
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: add file watcher support for dynamic module bootstrap extensions
Additional Description:
This adds filesystem watcher support for bootstrap extension dynamic modules, allowing modules to monitor files for changes on the main thread event loop.
Modules can create a file watcher, register one or more paths to watch, and receive callbacks when watched files are modified. This uses Envoy's existing Filesystem::Watcher internally.
This is useful for modules that need to react to file changes at runtime — for example, reloading configuration files, etc
The implementation adds:
on_file_changed) called by Envoy when a watched file changesfile_watcher_new,file_watcher_add_watch,file_watcher_delete)for modules to manage file watchers
Risk Level: Low
Testing: Unit and Integration test added
Docs Changes:
Release Notes: N.A
Platform Specific Features: N.A