Remove ScopeStatsLimitSettings: no longer needed since stats dropped …#44208
Closed
RepoRonin wants to merge 1 commit intoenvoyproxy:mainfrom
Closed
Remove ScopeStatsLimitSettings: no longer needed since stats dropped …#44208RepoRonin wants to merge 1 commit intoenvoyproxy:mainfrom
RepoRonin wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
…shared memory ScopeStatsLimitSettings was used to cap per-scope stat counts so they would fit in a shared memory block. Stats no longer use shared memory, so these limits serve no purpose. The command-line flags that set them were deprecated in envoyproxy#5910 (2019) and later removed. Remove the struct, the limits_ member from ScopeImpl, the three overflow counters (counters_overflow_, gauges_overflow_, histograms_overflow_) from ThreadLocalStoreImpl, the ensureOverflowStats() helper, and all the limit-check branches in safeMakeStat and histogramFromStatNameWithTags. Update all createScope/scopeFromStatName signatures across production code, mocks, and integration test helpers accordingly.
|
Hi @RepoRonin, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
RepoRonin
had a problem deploying
to
external-contributors
GitHub Actions
Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44162
stats: remove ScopeStatsLimitSettings and per-scope stat overflow counters
Additional Description : ScopeStatsLimitSettings was previously used to limit the number of
counters, gauges, and histograms in a shared memory block per scope.
Since stats no longer use shared memory, these limits have no effect
and there is no way to set them. The command-line options were
deprecated in #5910 (2019) and removed shortly after.
This removes the dead code entirely.
Note: This PR was developed with the assistance of generative AI
The changes have been reviewed and understood by the author.
Risk Level: Low
Testing: No new tests needed. Existing tests continue to pass — the removed parameters had default values of {} (no limit) everywhere, so no behavior changes.
Docs Changes: None
Release Notes: None
Platform Specific Features: None
Deprecated: Removes ScopeStatsLimitSettings struct and the limits parameter from Scope::createScope and Scope::scopeFromStatName.