filter_state: remove checks for read-only#44343
Open
ggreenway wants to merge 2 commits intoenvoyproxy:mainfrom
Open
filter_state: remove checks for read-only#44343ggreenway wants to merge 2 commits intoenvoyproxy:mainfrom
ggreenway wants to merge 2 commits intoenvoyproxy:mainfrom
Conversation
The checks for mutable vs read-only have caused many subtle runtime bugs, and have not provided much benefit. The parameter for read-only vs mutable is now ignored, and will be removed from the codebase in phases. Signed-off-by: Greg Greenway <ggreenway@apple.com>
Signed-off-by: Greg Greenway <ggreenway@apple.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
adisuissa
reviewed
Apr 9, 2026
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
From a high-level the direction looks good to me, but just wanted to clarify that it is unclear to me why in #4820 it was decided to add the mutable state, instead of just changing it to always be mutable. I don't have sufficient context on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checks for mutable vs read-only have caused many subtle runtime bugs, and have not provided much benefit.
The parameter for read-only vs mutable is now ignored, and will be removed from the codebase in phases.
Commit Message:
Additional Description:
Risk Level: Low
Testing: Updated tests
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]