dynamic_modules: add is_validation_mode ABI callback for module optimizaion#44417
Merged
agrawroh merged 1 commit intoenvoyproxy:mainfrom Apr 13, 2026
Merged
dynamic_modules: add is_validation_mode ABI callback for module optimizaion#44417agrawroh merged 1 commit intoenvoyproxy:mainfrom
agrawroh merged 1 commit intoenvoyproxy:mainfrom
Conversation
…ization Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
agrawroh
requested review from
mathetake,
mattklein123 and
wbpcode
as code owners
agrawroh
force-pushed
the
agrawroh/dm-vmode
branch
from
d031df8 to
ec06712
Compare
wbpcode
approved these changes
Apr 13, 2026
Copilot AI
pushed a commit
to mmorel-35/envoy
that referenced
this pull request
Apr 13, 2026
…izaion (envoyproxy#44417) ## Description This PR adds a new `envoy_dynamic_module_callback_is_validation_mode()` to the dynamic modules common ABI so that any module like Bootstrap, HTTP filter, network filter, etc. could detect when Envoy is running in the `--mode validate`. This lets modules optimize by only parsing/validating their config without performing expensive operations like provider lookups or loading external resources when we are in the non-production mode. --- **Commit Message**: dynamic_modules: add is_validation_mode ABI callback for module optimizaion **Additional Description:** Added a new `envoy_dynamic_module_callback_is_validation_mode()` to the dynamic modules common ABI. **Risk Level**: Low **Testing**: Added Tests **Docs Changes**: Added **Release Notes:** Added Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com> Co-authored-by: mmorel-35 <6032561+mmorel-35@users.noreply.github.com>
krinkinmu
pushed a commit
to grnmeira/envoy
that referenced
this pull request
Apr 20, 2026
…izaion (envoyproxy#44417) ## Description This PR adds a new `envoy_dynamic_module_callback_is_validation_mode()` to the dynamic modules common ABI so that any module like Bootstrap, HTTP filter, network filter, etc. could detect when Envoy is running in the `--mode validate`. This lets modules optimize by only parsing/validating their config without performing expensive operations like provider lookups or loading external resources when we are in the non-production mode. --- **Commit Message**: dynamic_modules: add is_validation_mode ABI callback for module optimizaion **Additional Description:** Added a new `envoy_dynamic_module_callback_is_validation_mode()` to the dynamic modules common ABI. **Risk Level**: Low **Testing**: Added Tests **Docs Changes**: Added **Release Notes:** Added Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
envoy_dynamic_module_callback_is_validation_mode()to the dynamic modules common ABI so that any module like Bootstrap, HTTP filter, network filter, etc. could detect when Envoy is running in the--mode validate.This lets modules optimize by only parsing/validating their config without performing expensive operations like provider lookups or loading external resources when we are in the non-production mode.
Commit Message: dynamic_modules: add is_validation_mode ABI callback for module optimizaion
Additional Description: Added a new
envoy_dynamic_module_callback_is_validation_mode()to the dynamic modules common ABI.Risk Level: Low
Testing: Added Tests
Docs Changes: Added
Release Notes: Added