harden JsonEscaper by removing sprintf and clarifying byte handling#44474
Open
rootvector2 wants to merge 1 commit into
Open
harden JsonEscaper by removing sprintf and clarifying byte handling#44474rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
|
Hi @rootvector2, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Member
|
@rootvector2 please fix DCO |
54a36fb to
e3d0176
Compare
Member
|
@rootvector2 Please fix the failing triggers. /wait |
Signed-off-by: rootvector2 <dxbnaveed.k@gmail.com>
e3d0176 to
735104c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Description:
Risk Level:
Low. The change is localized to JSON escaping utility logic and test coverage was expanded for edge cases.
Testing:
Docs Changes:
None.
Release Notes:
None.
Platform Specific Features:
None.
[Optional Runtime guard:]
Not needed.
[Optional Fixes #Issue]
N/A
[Optional Fixes commit #PR or SHA]
N/A
[Optional Deprecated:]
N/A