Skip to content

ext_authz: add method_override to HttpService #44564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
derekargueta wants to merge 2 commits into
base: main
Choose a base branch
from
+878 −1
Open

ext_authz: add method_override to HttpService #44564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72f3047
ext_authz: add method_override to HttpService
derekargueta Apr 21, 2026
70bdf2c
Merge remote-tracking branch 'upstream/main' into dargueta-ext-authz-…
derekargueta Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion api/envoy/extensions/filters/http/ext_authz/v3/ext_authz.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ message BufferSettings {
// metadata as well as body may be added to the client's response. See :ref:`allowed_client_headers
// <envoy_v3_api_field_extensions.filters.http.ext_authz.v3.AuthorizationResponse.allowed_client_headers>`
// for details.
// [#next-free-field: 11]
// [#next-free-field: 12]
message HttpService {
option (udpa.annotations.versioning).previous_message_type =
"envoy.config.filter.http.ext_authz.v2.HttpService";
Expand All @@ -502,6 +502,12 @@ message HttpService {
// Only one of ``path_prefix`` or ``path_override`` may be set.
string path_override = 10;

// Overrides the HTTP method of the authorization request sent to the authorization service.
Copy link
Copy Markdown
Contributor

@adisuissa adisuissa Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high-level question:
not sure I fully understand why the method needs an override or why it is dependent on the incoming request... Shouldn't it just be decided by the contents of server_uri?

// If not set, the original request method is forwarded. This is useful when the authorization
// service exposes a single fixed endpoint (e.g. ``POST /auth``) regardless of the original
// request method.
string method_override = 11;

// Settings used for controlling authorization request metadata.
AuthorizationRequest authorization_request = 7;

Expand Down
Loading
Loading