dynamic modules: port Rust sdk to Golang to match envoy ABI capabilities#44713
Draft
AdamEAnderson wants to merge 39 commits into
Draft
dynamic modules: port Rust sdk to Golang to match envoy ABI capabilities#44713AdamEAnderson wants to merge 39 commits into
AdamEAnderson wants to merge 39 commits into
Conversation
Signed-off-by: Adam Anderson <6754028+AdamEAnderson@users.noreply.github.com>
# Conflicts: # source/extensions/dynamic_modules/sdk/go/shared/api.go # source/extensions/dynamic_modules/sdk/go/shared/http.go # source/extensions/dynamic_modules/sdk/go/shared/mocks/mock_api.go # source/extensions/dynamic_modules/sdk/go/shared/mocks/mock_http.go Signed-off-by: Adam Anderson <6754028+AdamEAnderson@users.noreply.github.com>
Contributor
Author
|
fyi @wbpcode since you're working on similar stuff too im planning on working on porting the tests tomorrow |
Member
|
This PR have done the network SDK #44678 and it would be great if you can split your PR to multiple minor PR for every module, like tracer, cluster and so on. |
# Conflicts: # source/extensions/dynamic_modules/sdk/go/abi/network.go # source/extensions/dynamic_modules/sdk/go/sdk.go Signed-off-by: Adam Anderson <6754028+AdamEAnderson@users.noreply.github.com>
Signed-off-by: Adam Anderson <6754028+AdamEAnderson@users.noreply.github.com>
Signed-off-by: Adam Anderson <6754028+AdamEAnderson@users.noreply.github.com>
Signed-off-by: Adam Anderson <6754028+AdamEAnderson@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Adam Anderson <6754028+AdamEAnderson@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: dynamic modules: port Rust sdk to Golang to match envoy ABI capabilities
Additional Description: the dynamic modules Golang SDK supports only HTTP filters. Updated the SDK using the existing code and the Rust SDK as an example to reach full parity with the ABI header.
Risk Level: low
Testing: todo
Docs Changes: n/a
Release Notes: included
Platform Specific Features: n/a
written with plenty of help from claude (cause its mostly a port)