reverse_tunnel: add skip_rebalancing config#44835
Open
aakugan wants to merge 2 commits into
Open
Conversation
Signed-off-by: aakugan <aakashganapathy2@gmail.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Contributor
|
Please merge and fix conflicts. |
basundhara-c
approved these changes
May 17, 2026
tyxia
approved these changes
May 22, 2026
Member
tyxia
left a comment
tyxia
left a comment
There was a problem hiding this comment.
LGTM, Thanks!
@agrawroh Do you want to take a look as code owner/maintainer, the other owner @basundhara-c has approved it.
| // When true, skip worker-thread rebalancing for accepted reverse tunnel connections. | ||
| // This avoids the cross-worker lock in pickLeastLoadedSocketManager. | ||
| // Default: false (rebalancing enabled). | ||
| bool skip_rebalancing = 8; |
Member
There was a problem hiding this comment.
Will this skip_rebalancing ever be default true? Does not seem to be, but just check. If it will be default to true we should use BoolValue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message
reverse_tunnel: add skip_rebalancing config
Additional Description
Adds a skip_rebalancing bool to the reverse tunnel filter config. When enabled, accepted connections skip the pickLeastLoadedSocketManager path and its WriterMutexLock, avoiding cross-worker contention for
deployments that don't need connection rebalancing.
Testing
Unit tests.
Existing integ tests ensure that there are no behaviour regressions.