decoder state leakage across multiple messages#44860
Open
jmestwa-coder wants to merge 1 commit into
Open
Conversation
|
Hi @jmestwa-coder, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Member
|
You'll need to fix the DCO before this will be accepted. See CONTRIBUTING.md for instructions. |
Member
|
/wait |
Signed-off-by: jmestwa-coder <jmestwa@gmail.com>
fea3bd3 to
66b289f
Compare
Author
|
Added DCO sign-off and updated the commit. Please let me know if anything else is needed. |
Contributor
|
/wait |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix state leakage in SIP decoder where
clenandfull_msg_lenwere not reset between iterations inDecoder::reassemble().Problem
When multiple SIP messages are present in a single buffer:
Fix
Move
clenandfull_msg_leninside the loop so they are reinitialized per message.Test
Adds a regression test that:
newDecoderEventHandlercalled twice)The test fails before the fix and passes after.